Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Fix missing ADDON variable #1660

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

  • In its initial form this is limited only to accessory, but I want to fix all issues in all components with ADDON.

    This behaviour seems to be inconsistent and I was to address that in this PR. However, in order to better understand what solution might be the best: What is the purpose of ADDON exactly?

@PabstMirror
Copy link
Contributor

PabstMirror commented Apr 30, 2024

IIRC

ADDON = false;
initCode
ADDON = true;

was designed so that you can diagnose if there is an error in init code that stops execution
(undefined/false/true)
I think it is still possible for some kinds of errors to fully break preInit/postInit for other modules

but IMHO the rpt will do a better job of showing the error location than checking these vars

edit: Also, I know some mods check these vars for the existence of mods (instead of checking cfgPatches)

@PabstMirror PabstMirror added this to the 3.18.0 milestone May 1, 2024
@johnb432
Copy link
Contributor Author

johnb432 commented May 1, 2024

@PabstMirror I want to fix all inconsistencies with ADDON then. Define them where necessary and make sure that, regardless of machine type, the ADDON variable for each component is set to true, if preInit completes successfully. I'll do the same for ACE at some point.
However, given you've approved the PR as is, do you want me to make separate PRs for individual components, another PR with all changes combined or utilise this one?

@PabstMirror
Copy link
Contributor

feel free to do it all in this PR or whatever is easiest

@jonpas jonpas changed the title Misc. - Fix missing ADDON variable General - Fix missing ADDON variable May 2, 2024
@johnb432 johnb432 requested a review from PabstMirror May 3, 2024 22:14
@jonpas jonpas merged commit eedb286 into CBATeam:master Jun 13, 2024
4 checks passed
@johnb432 johnb432 deleted the misc-add-ADDON branch June 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants