fix strange modifier key behavior #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ should the key be released in the same frame, the keyUp would happen after the keyDown. The "true" state is unreliable as described above, but if the state is false, the key is guaranteed not held, so we can make the modifier key release frame precise. |
Killswitch00
approved these changes
Apr 27, 2017
commy2
added a commit
that referenced
this pull request
May 1, 2017
) * fix keyHandler becoming unremovable if added two different keys * fix strange modifier key behavior (#654) * fix strange modifier key behaviour * disable modifier state in keyDown if released
commy2
added a commit
that referenced
this pull request
May 1, 2017
* add mouse button translations to custom dik codes * fix keyHandler becoming unremovable if added to two different keys (#653) * fix keyHandler becoming unremovable if added two different keys * fix strange modifier key behavior (#654) * fix strange modifier key behaviour * disable modifier state in keyDown if released
commy2
added a commit
that referenced
this pull request
May 1, 2017
* use last possible single key as array size * delete superfluous check, fix header * roll less, but bigger numbers to generate random hashkey * header formatting * only compile functions on machines with interface * add mission display ui events directly on display init * rename display load functions for naming conventions * prepare mouse handers in zeus display * fix issues with blocking key events * isEqualTo for maximum performance :S * fix no return value making blocking undefined * simplify * better variable name * remove a superfluous check * add a comment to seperate key handler code from other stuff * add support for mouse keys and the scroll wheel * add mouse button translations (#652) * add mouse button translations to custom dik codes * fix keyHandler becoming unremovable if added to two different keys (#653) * fix keyHandler becoming unremovable if added two different keys * fix strange modifier key behavior (#654) * fix strange modifier key behaviour * disable modifier state in keyDown if released
commy2
added a commit
that referenced
this pull request
May 20, 2017
* Mouse support for CBA_fnc_addKeyHandler (#651) * use last possible single key as array size * delete superfluous check, fix header * roll less, but bigger numbers to generate random hashkey * header formatting * only compile functions on machines with interface * add mission display ui events directly on display init * rename display load functions for naming conventions * prepare mouse handers in zeus display * fix issues with blocking key events * isEqualTo for maximum performance :S * fix no return value making blocking undefined * simplify * better variable name * remove a superfluous check * add a comment to seperate key handler code from other stuff * add support for mouse keys and the scroll wheel * add mouse button translations (#652) * add mouse button translations to custom dik codes * fix keyHandler becoming unremovable if added to two different keys (#653) * fix keyHandler becoming unremovable if added two different keys * fix strange modifier key behavior (#654) * fix strange modifier key behaviour * disable modifier state in keyDown if released * squash-CBA_fnc_addKeybind-redo (#656) * fix a script error * add function to translate keys * joinString * fix rebinding would delete default keyup handler * CfgFunctions * display multiple keybinds in diary * fix for travis * remake keybinding ui and add mouse support (#638) * remake rebinding ui for mouse support * remember last selected addon in keybinding ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
The shift/control/alt parameters passed by the keyDown/Up events are really crappy. When you released a key, say shift, the "shift" parameter will still report true for all keyDown/Up events that happen up to about half a second later, even though the keyUp event for "shift" already occurred.
With this PR we look for the modifier keys themselves and store their states in variables. This makes the behavior way more intuitive and predictable.
By doing this, this PR also adds modifier support to the mouse wheel.