Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug watching for statements that run on a remote machine #658

Merged
merged 14 commits into from
May 7, 2017

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented May 1, 2017

Adds addition statement watchers to the debug menu that run on the server
They exec on the server and return the results back to the client.

Requires EnableTargetDebug= 1; in description.ext or 3den

image

@commy2
Copy link
Contributor

commy2 commented May 2, 2017

Any reason why GVAR(watchOutput) is an RscEdit? You cannot edit the output lines.

@PabstMirror
Copy link
Contributor Author

Allows you to copy the text

@commy2
Copy link
Contributor

commy2 commented May 2, 2017

Ah! Nice.

@commy2
Copy link
Contributor

commy2 commented May 2, 2017

http://i.imgur.com/XhMqg8e.jpg

@commy2
Copy link
Contributor

commy2 commented May 2, 2017

Doesn't work so good with "Large" and "Very Large" ui size.
http://i.imgur.com/4kFwHch.jpg

@PabstMirror PabstMirror changed the title Debug watching for statements that run on server Debug watching for statements that run on a remote machine May 3, 2017
@commy2
Copy link
Contributor

commy2 commented May 3, 2017

Works great! Tested in local hosted MP. Amazing feature!

@dedmen
Copy link
Contributor

dedmen commented May 3, 2017

Just need another remoteExec button to execute code on a specific client

@jonpas
Copy link
Member

jonpas commented May 3, 2017

Just need another remoteExec button to execute code on a specific client

I agree, could replace the "Server Exec" with "Target Exec" as well, since server can be selected in the drop-down as well.

@commy2
Copy link
Contributor

commy2 commented May 4, 2017

This line is the gem of this PR:

_this = ([nil] apply compile _this) select 0;

It solves this annoying problem:

_blub = {_blah = 1};
_blob = call _blub; // generic error in expression
systemChat str [_blob];
_blub = {_blah = 1}; 
_blob = [nil] apply _blub select 0;
systemChat str [_blob]; // [<null>]

replace SERVER EXEC button with TARGET EXEC button
@commy2 commy2 merged commit 4dfdd9a into master May 7, 2017
@commy2 commy2 deleted the serverWatchDebug branch May 7, 2017 17:38
@commy2 commy2 added this to the 3.4 milestone May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants