Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tool to report performance of state machines #671

Merged
merged 5 commits into from
May 20, 2017

Conversation

PabstMirror
Copy link
Contributor

Tag @BaerMitUmlaut

Reports rough average runtime for each statemachine.
Includes both the statemachine's functions time + CBA's clockwork time.
diag_tickTime has limited timer accuracy, but with a longer run time it seems to average out well enough.

No impact on normal release, requires #define to work.

Example RPT:

 CBA State Machine Results:
 ------------------ [Time: 59.4] -------------------------
 0: [ace_medical_blood] Average: 1.071 ms [4.031s / 3763]
 1: [ace_medical_ai] Average: 0.103 ms [0.388s / 3763]

@PabstMirror PabstMirror added this to the 3.4 milestone May 7, 2017
@BaerMitUmlaut
Copy link
Contributor

Two things:

  • Why not save the counter on the state machine itself instead of in a GVAR?
  • Personally I'd not use another prefix for the function, the name of the function is almost 50 characters long, I'd rather mention in the header that this is only for development purposes

@PabstMirror
Copy link
Contributor Author

  1. Can still track removed state machine and what their performance was
  2. Fixed

@commy2 commy2 merged commit f62038f into master May 20, 2017
@commy2 commy2 deleted the statemachinePerfCounter branch May 20, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants