Submit language form on language link click #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
======================================
Coverage 89.3% 89.3%
======================================
Files 41 41
Lines 1506 1506
======================================
Hits 1345 1345
Misses 161 161 |
sevein
reviewed
Jul 26, 2018
accesspoc/templates/base.html
Outdated
| {% get_available_languages as LANGUAGES %} | ||
| {% get_language_info_list for LANGUAGES as languages %} | ||
| {% for language in languages %} | ||
| <a class="dropdown-item" href="javascript:;" onclick="document.langForm.language.value='{{ language.code }}'; document.langForm.submit();">{{ language.name_local|capfirst }} ({{ language.code }})</a> |
There was a problem hiding this comment.
You came this far without a single .js file but perhaps you should have one now to avoid mixing code and markup. It used to be a bad practice IIRC.
sevein
reviewed
Jul 26, 2018
| <script type="text/javascript" src="{% static 'js/jquery-3.2.1.min.js' %}"></script> | ||
| <script type="text/javascript" src="{% static 'js/popper.min.js' %}"></script> | ||
| <script type="text/javascript" src="{% static 'js/bootstrap.min.js' %}"></script> | ||
| <script type="text/javascript" src="{% static 'js/custom.js' %}"></script> |
There was a problem hiding this comment.
FWIW HTML 5's type defaults to text/javascript. It's fine to be explicit but just for your information.
To avoid having a submit button inside the language drop-down to send the language change request, create a hidden field inside the form for the language and remove the current check-boxes. Add drop-down links outside the form and change the language input value on link click and submit the form. Squashed commit of the following: commit 6a84f23 Author: José Raddaoui Marín <raddaouimarin@gmail.com> Date: Thu Jul 26 20:23:17 2018 +0200 Move form modification and submission to JS file commit 3103c50 Author: José Raddaoui Marín <raddaouimarin@gmail.com> Date: Thu Jul 26 16:35:30 2018 +0200 Submit language form on language link click To avoid having a submit button inside the language drop-down to send the language change request, create a hidden field inside the form for the language and remove the current check-boxes. Add drop-down links outside the form and change the language input value on link click and submit the form. Include the JS code used for this behavior in the link attributes to avoid loading an entire custom JS only for this.
jraddaoui
force-pushed
the
dev/issue-16-lang-form
branch
from
6a84f23
to
333f012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having a submit button inside the language drop-down to send
the language change request, create a hidden field inside the form for
the language and remove the current check-boxes. Add drop-down links
outside the form and change the language input value on link click and
submit the form.
Connects to #16.