-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve runtest defaults, add changelog, update --version flag, add --force flag, refactor Rlibs #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Also, delete the "test_dev" GHA WF as it refers to some 9999.9999 version which does not exist and include that in this PR.
This comment was marked as resolved.
This comment was marked as resolved.
My test run failed in the GO enrichment rule:
Must be failing on chipenrich:
The good news is all other jobs passed! |
Finished testing these changes - everything went to completion. ready for you to test again @kelly-sovacool ! |
test run submitted bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=init --workdir=/data/sovacoolkl/carlisle_test_iss-113_2
bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=runtest --workdir=/data/sovacoolkl/carlisle_test_iss-113_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all jobs in my test run completed successfully 🎉
Changes
--force
flag to allow for re-initialization of a workdirtestrun
in DESEQ2testrun
, essentially runningtinytest
as default and removingtinytest
as an optionVERSION
file instead of github repo linkCHANGELOG
Issues
init
#97carlisle --version
should print version number #112testrun
by updating params, adding mm10 #115linking distal enhancers
#125PR Checklist
(
Strikethroughany points that are not applicable.)CHANGELOG.md
with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/