Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtest defaults, add changelog, update --version flag, add --force flag, refactor Rlibs #117

Merged
merged 35 commits into from
Feb 21, 2024

Conversation

slsevilla
Copy link
Contributor

@slsevilla slsevilla commented Feb 8, 2024

Changes

  • Adds a --force flag to allow for re-initialization of a workdir
  • Fixes error with testrun in DESEQ2
  • Decreases the number of samples being run with testrun, essentially running tinytest as default and removing tinytest as an option
  • Reads version from VERSION file instead of github repo link
  • Added a CHANGELOG
  • Refactor R library handling
  • Adds missing mm10 parameters
  • Removes some testing from annotation report gopeaks due to latency

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Copy link
Member

@kopardev kopardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Also, delete the "test_dev" GHA WF as it refers to some 9999.9999 version which does not exist and include that in this PR.

@kelly-sovacool

This comment was marked as resolved.

kelly-sovacool

This comment was marked as resolved.

@slsevilla slsevilla changed the title Iss 113 Improve runtest defaults, add changelog, update --version flag, add --force flag Feb 8, 2024
@kelly-sovacool
Copy link
Member

kelly-sovacool commented Feb 9, 2024

My test run failed in the GO enrichment rule:

Quitting from lines 19-52 [setup] (_go_enrichment.Rmd)
Error in `install.packages()`:
! unable to install packages
Backtrace:
  1. BiocManager::install(new.packages, INSTALL_opts = "--no-lock")
  2. BiocManager:::.install(...)
  3. BiocManager:::.install_repos(...)
  4. BiocManager:::.inet_install.packages(...)
  6. base::tryCatch(...)
  7. base (local) tryCatchList(expr, classes, parentenv, handlers)
  8. base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
  9. value[[3L]](cond)
 10. BiocManager:::.inet_error(e)
Execution halted

Must be failing on chipenrich:

list.of.bioconductor.packages=c("chipenrich")

The good news is all other jobs passed!

@slsevilla slsevilla changed the title Improve runtest defaults, add changelog, update --version flag, add --force flag Improve runtest defaults, add changelog, update --version flag, add --force flag, refactor Rlibs Feb 14, 2024
@slsevilla
Copy link
Contributor Author

Finished testing these changes - everything went to completion. ready for you to test again @kelly-sovacool !

@kelly-sovacool
Copy link
Member

test run submitted

bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=init --workdir=/data/sovacoolkl/carlisle_test_iss-113_2
bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=runtest --workdir=/data/sovacoolkl/carlisle_test_iss-113_2

Copy link
Member

@kelly-sovacool kelly-sovacool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all jobs in my test run completed successfully 🎉

@slsevilla slsevilla merged commit 71fd514 into master Feb 21, 2024
1 of 2 checks passed
@kelly-sovacool kelly-sovacool deleted the iss-113 branch April 10, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment