Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix McPoodle broadcast raw format output #1523

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[FIX] Fix McPoodle broadcast raw format output #1523

merged 1 commit into from
Mar 30, 2023

Conversation

dhouck
Copy link
Contributor

@dhouck dhouck commented Mar 30, 2023

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Currently this only works with field 2, which is rarely used; the issue is that field 2 is output either way and this format only supports one field. This PR gets rid of the extraneous output; the writeraw function doesnʼt read XDS so it wasnʼt doing any good in this case anyway.

@dhouck
Fix McPoodle broadcast raw format output
bfe09bd 
The broadcast raw format *must* contain data from onely one field, or
neither `ccextractor` nor McPoodle's tools can actually read it.  Since
we don't actually get XDS data from `writeraw`, there's no reason to
keep the call for field 2.
@dhouck dhouck mentioned this pull request Mar 30, 2023
Open
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/87
Teletext 0/21
WTV 0/13
XDS 0/34

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit cf2d207 into CCExtractor:master Mar 30, 2023
@dhouck dhouck deleted the raw-format branch March 30, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhouck @ccextractor-bot @cfsmp3