Add query to get pod labels and generate report by class labels #106
+217
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We specifically get pod labels where the class label isn't empty. This label is currently only expected to be found for the rhods-notebooks namespace. Once we have the pod labels, we insert this label with the cpu metrics. This is arbritary, it could have been merged with memory metrics. Finally, when we are merging our metrics we add this label to the merged_data dictionary which is ultimately used for processing.
This is basically like how write_metrics_by_namespaces works except: - it doesn't gather data from coldfront - instead of namespaces we use namespace+classname as a project name to create ProjectInvoice objects.
knikolla
approved these changes
Feb 25, 2025
also remove an unwanted newline
|
@QuanMPhm I have addressed your comments. |
QuanMPhm
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a request so we can get a breakdown of the rhods-notebooks namespace by class. There's a mutating webhook that adds a label to the pod which is what we use to figure out which class a pod belongs to.
Note that this does not mess with the original invoice and instead generates a new report.