Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pcl depends #24

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Update pcl depends #24

merged 1 commit into from
Oct 14, 2015

Conversation

efernandez
Copy link
Contributor

This fixes the following error when running rosdep install --from-paths src -iy from the workspace with scan_tools:

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
scan_to_cloud_converter: Cannot locate rosdep definition for [pcl]
laser_ortho_projector: Cannot locate rosdep definition for [pcl]
laser_scan_matcher: Cannot locate rosdep definition for [pcl]

@130s
Copy link
Collaborator

130s commented Oct 14, 2015

@efernandez I assume this PR is targeted for post-Hydro distros where pcl as a package got unavailable?

@ubuntuslave
Copy link
Collaborator

I can't test this since I'm still running fuerte on my laptops. @130s can you please see if the pcl dependency fix given by @efernandez works in the indigo and hydro branches?

@130s 130s mentioned this pull request Oct 14, 2015
@130s
Copy link
Collaborator

130s commented Oct 14, 2015

I confirmed that this PR:

  • works on Indigo

  • solves a problem on Hydro too. Without this PR, rosdep fails:

    $ sudo apt-get purge ros-hydro-pcl*
    $ rosdep install --from-paths src --ignore-src --rosdistro hydro -y
    ERROR: the following packages/stacks could not have their rosdep keys resolved
    to system dependencies:
    scan_to_cloud_converter: Cannot locate rosdep definition for [pcl]
    laser_ortho_projector: Cannot locate rosdep definition for [pcl]
    laser_scan_matcher: Cannot locate rosdep definition for [pcl]
    

Therefore +1, and I'm merging. I'll cherry-pick into branches too.

130s added a commit that referenced this pull request Oct 14, 2015
@130s 130s merged commit 0a397e4 into CCNYRoboticsLab:master Oct 14, 2015
130s added a commit that referenced this pull request Oct 14, 2015
130s added a commit that referenced this pull request Oct 14, 2015
@efernandez efernandez deleted the fix_deps branch October 14, 2015 19:41
@efernandez
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants