Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev-6648] add column to viz #1017

Merged
merged 7 commits into from
Jan 20, 2024
Merged

[Dev-6648] add column to viz #1017

merged 7 commits into from
Jan 20, 2024

Conversation

joshlacey
Copy link
Collaborator

@joshlacey joshlacey commented Jan 11, 2024

In order to add a column to the visualization I'll need to pivot two columns into one column. This will mean that I will have to override the colorScale that is passed from the CdcChart. I'll be handing this logic in the PieChart since adding the column is going to be specific to PieChart only. Once the instructions for a need for a pivot are passed to the PieChart, it will do the necessary steps to pivot the data and recreate the colorscale. This colorscale and updated data will then be passed to the Legend. Legend.Component will become a part of the PieChart component itself and Legend.tsx (the wrapper) will have logic to exclude rendering if the viz type is PieChart.

@joshlacey joshlacey marked this pull request as ready for review January 11, 2024 20:43
@adamdoe adamdoe added this to the 4.24.2 milestone Jan 16, 2024
@adamdoe adamdoe merged commit 6c0c44d into dev Jan 20, 2024
@joshlacey joshlacey deleted the dev-6648-add-column-to-viz branch March 22, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants