Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-8698] Applies Filters on MultiDash Switch #1389

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[DEV-8698] Applies Filters on MultiDash Switch #1389

merged 3 commits into from
Jul 16, 2024

Conversation

mpallansch
Copy link
Collaborator

No description provided.

@mpallansch mpallansch requested a review from adamdoe July 9, 2024 14:40
adamdoe
adamdoe approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@adamdoe adamdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpallansch this lgtm and can be squash/merged

joshlacey
joshlacey reviewed Jul 10, 2024
View reviewed changes
packages/dashboard/src/CdcDashboardComponent.tsx
@@ -265,6 +265,10 @@ export default function CdcDashboard({ initialState, isEditor = false, isDebug =
loadAPIFilters(config.dashboard.sharedFilters)
}, [isEditor, isPreview])

useEffect(() => {
updateDataFilters()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you move this into the first useEffect right after loadAPIFilters it would also work. Did you try that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is related to this issue you mentioned on 3. in dev-8409

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is related to this issue you mentioned on 3. in dev-8409

I don't believe so, 3 in 8409 is related to the value not being checked for null in packages/dashboard/src/helpers/generateValuesForFilter.ts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you move this into the first useEffect right after loadAPIFilters it would also work. Did you try that?

Yes, I had tried that, but the useEffect only has isEditor and isPreview as dependencies, so it doesn't fire when the dashboard multi-tab is changed. I can combine the useEffects possibly, including state.config?.activeDashboard on the first useEffect, but then API filters will reload every time the multi-tab changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshlacey I combined the useeffects in the latest commit, let me know if looks better now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should update the shared filters and then pass the result to loadAPIFilters. that's what I'm doing in the dashboard filters refactor branch

@adamdoe adamdoe changed the title Applies Filters on MultiDash Switch [DEV-8698] Applies Filters on MultiDash Switch Jul 10, 2024
joshlacey
joshlacey reviewed Jul 16, 2024
View reviewed changes
packages/dashboard/src/CdcDashboardComponent.tsx
const clonedState = _.cloneDeep(state)
if (sharedFilters) clonedState.config.dashboard.sharedFilters = sharedFilters
const newFilteredData = getFilteredData(clonedState)
dispatch({ type: 'SET_FILTERED_DATA', payload: newFilteredData })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the filtered data have to do with the values on the dashboard filter?

@mpallansch mpallansch merged commit 5ab005e into dev Jul 16, 2024
1 check passed
adamdoe added a commit that referenced this pull request Jul 30, 2024
@adamdoe @joshlacey
@Atash3000 @mpallansch @Matt-DiPaolo
Dev (#1431)
9dfaed0 
* [DEV-8444] Sankey > Update Tooltips and Types (#1348)

* [DEV-8445] 4.24.6 > Move chart height selection up in the editor (#1351)

* [DEV-8312] Remove Data Designer Steps for Sankey (#1352)

* [maps] organize helper functions and add tests (#1377)

* [maps] organize helper functions and add tests

* [maps] update test locations

* bug: [dev-8575] ardi multi viz (#1374)

* bug dev-8575 ardi multi viz

* refactored from comments

* Testing pipeline (#1345)

* unit testing pipeline

* removed matrix strategy

* enhancement: [DEV-8191] multi select and pivot table updates (#1363)

* enhancement dev-8191 multi select and pivot table updates

* removed pivot test from filters since filter doesnt do pivot now

* [DEV-8234] Fix Date/category axis date orders (#1381)

* [dev] add pr template back in

* [dev] test casing

* [dev] Storybook > resolve deploy issue

* [hotfix] Fixes Crash When Switching from Combo to Bar (#1387)

* [DEV-8576] Update tooltip for zero & null values (#1384)

* [DEV-8576] Update tooltip for zero & null values

* [DEV-8576] Update function

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [hotfix] storybook and testing pipeline updates (#1394)

* [process-testing] process testing

* [process-testing] bump

* [process-testing] remove react testing library test

* [process-testing] remove comment

* added svg fix

---------

Co-authored-by: Lacey <pro7@cdc.gov>

* [DEV-7286] 4.24.7 > Inclusive Quantile Legend Opt In (#1353)

* [DEV-7286] 4.24.6 > Inclusive Quantile Legend Opt In

* [DEV-7286] Update logic and default values

* [DEV-7286] update coveUpdateWorker logic for 4.24.7

* [DEV-7286] Review Feedback

- Use lodash for unique values
- Reduce file size by removing large data files
- Compartmentalize functions for 4.24.7 updates

* [DEV-7286] Remove duplicate example file

* [DEV-8667] Add filled circles to line effect (#1385)

* [DEV-8667] Add Filled Circles to Line Effect

* [DEV-8667] Update tooltip text

* [DEV-8667] Update style

* [DEV-8667] update const

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [DEV-8445] update chart height tooltip (#1395)

* [DEV-8445] 4.24.6 > Move chart height selection up in the editor

* Fix for County Tooltip Position (#1388)

* [DEV-8445] Add chart height tooltip

---------

Co-authored-by: mpallansch <matthew.pallansch@gmail.com>

* Feature/dev 8312 (#1396)

* [DEV-8312] Remove Data Designer Steps for Sankey

* [DEV-8312] remove columns panel on sankey diagrams

* [dev] 4.24.7 > remove bar borders on line charts

* [DEV-8312] add configure button to sankey setup steps (#1398)

* [DEV-8312] Remove Data Designer Steps for Sankey

* [DEV-8312] remove columns panel on sankey diagrams

* [DEV-8312] add configure your data button to sankey

* [DEV-8622] 4.24.7 > remove unnecessary fields on sankey diagrams (#1399)

* feature: [dev-8574] Advanced Editor updates (#1372)

* feature dev-8574 advanced editor updates

* added fixes

* fixed imports in svg imports

* [DEV-7795] Responsive Annotations (#1397)

* [annotations] annotation start

* [annotations] continue working on annotations

* [annotations] add responsive options

* [annotations] add scaling for annotations in

* [annotations] 4.24.4 > Annotations

* [annotations] resolve drag and drop

* [annotations] 4.24.4 > Annotation Scaling Updates

* [annotations] working on annotations

* [annotations] continue working on annotations

* [annotations] add scaling for annotations in

* [annotations] annotations working

* [annotations] annotations working

* [annotations] continue work on annotations

* [annotations] 4.24.4 > Annotation scaling on date/time

* [annotations] working on markers

* [annotations] 4.24.5 > Annotation Updates

* [annotations] 4.24.5 > stop annotation from breaking on new.

* [annotations] update style of annotation

* [annotations] add bend

* [annotations] continue work to move

* [annotations] 4.24.5: Scaling for mobile labels

* [annotations] still working on annotation scaling

* [annotations] continue work on label positioning

* [annotations] scaling working

* [annotations] start adding in snapTo logic

* [annotations] 4.24.5 > Annotations without snap to resolved

* [annotations] center annotation when adding

* [annotations] continued work on annotations

* [annotations] Start scaffolding storybook items

* [annotations] add examples

* [annotations] add examples

* [annotations] delete files

* [annotations] cleanup

* [annotations] 4.24.5 > Annotation Feature

* [annotations-maps] map anontations

* [annotations-maps] continue work on map annotations

* [annotations-maps] 4.24.5 > Map Annotation Updates

* [annotations] test

* [annotations] Adjust width based on true svg dimensions

* [annotations] updates for line type when none

* [annotations] Annotation Updates for curved lines

* [annotations] add check for associate series

* [annotations] add bezier

* [annotations-maps] stash

* [annotations-maps] continue working on annotation scaling

* [annotations-maps] organization updates

* [annotations-maps] 4.24.6 > Annotations

* [annotations-maps] remove connection location

* [annotations-maps] Annotations > handle tabbing for annotations

* [annotations-maps] Start work on annotation list dropdown

* [annotations-maps] test

* [annotations-maps] continued work on labels

* [annotations-maps] Chart Annotation Updates

* [annotations-maps] continue work on annotations

* [annotations-maps] improve annotation dragging status

* [annotations-maps] update map annotations drag state

* [annotations-maps] testing locations

* [annotations-maps] 4.24.7 > annotation updateS

* [DEV-7795] part of merge

* [DEV-7795] remove bad import

* [DEV-7795] 4.24.7 > updates for annotations

* [DEV-7795] update saved dimensions when screen size is changed

* [DEV-7795] 4.24.6 > annotation update

* Attempts to Fix Positioning

* [DEV-7795-matt] Annotation Panel Changes on Charts

---------

Co-authored-by: mpallansch <matthew.pallansch@gmail.com>

* [DEV-4215] add brush functionality (#1386)

* [DEV-4215f] Add d3 Brush

* [DEV-4215f] Update brush

* [DEV-4215f] Add brush margin

* [DEV-4215f] remove redundant file

* [DEV-4215f] update rect element

* [DEV-4215f] update text element

* [DEV-4215f] Fix small errors

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [dev] fix svg paths

* [dev] Revert "[DEV-4215] add brush functionality (#1386)"

This reverts commit c7e633f.

* [dev] Revert "feature: [dev-8574] Advanced Editor updates (#1372)"

This reverts commit 56d002e.

* Feature [dev-8574] advanced editor updates (#1401)

* feature dev-8574 advanced editor updates

* added fixes

* fixed imports in svg imports

* fixed csv imports

* [dev] Revert "[DEV-8576] Update tooltip for zero & null values (#1384)

* [DEV-8727] Update missing data label (#1402)

* Bug: [Dev-8568] COVE: Dashboard Filter Values Not Updating From Data Change (#1370)

* Updates Dashboard Filters on Load of Dynamic Data

* Adds Example Config

* Removes Reference to Moved Function

* [DEV-8669] Fix bar labels font size (#1400)

* [dev] 4.24.7 > Update PR Template

* [dev] fix typos

* [DEV-8595] Add guards for sankey data (#1405)

* [DEV-8397] Fix CDC logo overlap territories (#1404)

* [DEV-8121] update table links font sizes (#1403)

* [DEV-8767] Fix formatter to handle strings properly (#1407)

* Feature: [dev-8409] dashboard filter refactor (#1390)

* feature dev-8490 dashboard filter refactor

* fixed conflicts

* added select from existing

* added fix for delete logic, and added fix for showMissingDataCellValue

* [DEV-8698] Applies Filters on MultiDash Switch (#1389)

* Applies Filters on MultiDash Switch

* Combines UseEffects

* [DEV-7763] Expand Collapse Buttons (#1360)

* fix [dev-8409] dashboard filters - changeFilterActive (#1410)

* [DEV-6410d] Add single series tooltip for Area and Line chart (#1406)

* [DEV-6410d] Add single series tooltip for Area and Line chart

* [DEV-6410d] update tooltips

* [DEV-6410d] Update function declaration

* Removes Extra Code From Merge Issue (#1409)

* Removes Extra Code From Merge Issue

* Name Change

* [DEV-8121a] Update font size (#1413)

* Feature/dev 8796 (#1411)

* [horizontal-labels] Fix labels issue

* [horizontal-labels] Update labels for bars

* [horizontal-labels] Update text padding

* [DEV-8796a] Add new test file (#1415)

* [dev] fix pie chart

* [dev] Fixes tooltip issue with forecasting charts

* [DEV-8821] fixes emergency dept visits page (#1417)

* [DEV-8832] add checks for data in filterVizData.ts (#1418)

* [dev] marker updates for annotations

* [dev] 4.24.7 > Annotation dropdown classes fix

* [dev] 4.24.7 hotfixes

* fix dev-8409 fixed filter preview styling and typo (#1420)

Co-authored-by: william Lacey <josh@williams-MacBook-Air.local>

* [dev] hotfix > annotation indexes

* [DEV-8846] Handle null values properly in table & tooltip (#1423)

* [DEV-8846] Handle null values properly in table & tooltip

* [DEV-8846] Update test case

* [dev] resolve geocode map

* added multi-tab fix (#1424)

* Dev 8698 and dev 8568 fixes (#1425)

* Fixes Multi-Dashboard Crash

* Fixes Chart Filter Not Updating From Data

* Fix: [dev-8574] advanced editor (#1428)

* fix dev-8574 for large files in advanced editor

* removed comment

* fix/ dev-8574 needed another field collapsed (#1429)

---------

Co-authored-by: Josh Lacey <williamjoshualacey@gmail.com>
Co-authored-by: Atash3000 <31108020+Atash3000@users.noreply.github.com>
Co-authored-by: mpallansch <matthew.pallansch@gmail.com>
Co-authored-by: Lacey <pro7@cdc.gov>
Co-authored-by: Matt-DiPaolo <125307923+Matt-DiPaolo@users.noreply.github.com>
Co-authored-by: william Lacey <josh@williams-MacBook-Air.local>
adamdoe added a commit that referenced this pull request Jul 30, 2024
@adamdoe @Atash3000
@mpallansch @joshlacey @Matt-DiPaolo @dependabot
Test (#1432)
f6b6145 
* [dev] Resolve 7020 issue

* [combo-filters] Fix  filters (#1315)

* Adds Respiratory Custom Example

* hotfix for filtered text package

* [DEV-8252] Clears URL Input After Load for Dashboard (#1310)

* [DEV-8322] Updates Filters When Switching Dashboard Tabs (#1308)

* [DEV-8261] Keeps Thicker Outline on Selected State When Hover (#1305)

* 4.24.5 > Filtered Text Styles

* [DEV-4215] Feature/dev 4215 (#1317)

* [DEV-4215] Update brush chart configs

* [DEV-4215] Update brush

* [DEV-4215] Update brush handler

* [DEV-4215] Fix useEffect data runner

* [DEV-7540] Remove responsive fonts from legend (#1312)

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [dev] resolve dashboard issues

* [DEV-7977] Add additional columns for Scatter plot tooltips (#1311)

* [DEV-7977] Add additional columns for Scatter plot tooltips

* [DEV-7977] Update  variables

* Adds Viewport Overrides for Tick Counts (#1293)

* [DEV-8106] Fixes Superscript in Header (#1323)

* [DEV-8252] Clears URL Input After Load for Dashboard (#1322)

* [DEV-8307] Updates Labels and Tooltips for Ticks (#1324)

* [DEV-8401] Fix. Data Preview for  Dashboard (#1320)

* [DEV-7696] dynamic footnotes (#1272)

* dev-7696-dynamic-footnotes

* added footnotes component

* fixed format before save

* added testing scenarios and fixed footnotes filtering

* added review changes

* [DEV-8102] Pie Chart > Legend Spacing (#1303)

* Fixes Bottom Legend Spacing With Pie Chart

* Attempts to Center Pie Charts More Consistently

* Fix for Table Icon

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [DEV-8008] trendline bar data driven switch (#1298)

* dev-8008 Ready for PR

* [dev-8008-Trendline-Bar-Data-Driven-Switch] trendline > fix casing

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* added fixes for storybook, removed stories broken by legacy markdown import, added base style to import scss variables, removed all configurations from editor (#1326)

* Feature/dev 7939 (#1318)

* [DEV-7939] Add Logic to handle missing data

* [DEV-7939] Add missing data to bars

* [DEV-7939] Update horizontal bars

* [DEV-7939] Update json back

* [DEV-7939] Update editor panel

* [DEV-7939] Update panel and types

* [DEV-7939] Update

* [DEV-7939] Update add guard

* [DEV-7939] Update vertical chart

* [DEV-7939] Update Types for Axis

* [DEV-7939] Update Panel permissions

* [DEV-7939] Fix undefined variable

* [DEV-7939] Fix Tooltip

* [DEV-7939] Remove console

* [DEV-7939] Add ErrorBoundary to Brush chart

* [DEV-7939] Fix constant

* [DEV-8008] Removed line to bar graph checks from EditorPanel (#1328)

Co-authored-by: Matthew DiPaolo <syf8@cdc.gov>

* [DEV-8254] Remove viz configs after removing row (#1302)

* Fixes Filters Being Erased By Placing Viz

* Removes Viz Configs After Removing Row

Fixes crash when opening filters after removing row with viz configs

* [DEV-7902] Update Bar Width Date Time Scaling (#1300)

* Changes Bar Width Calc Time Scale

* Fixes Stacked Bar Chart Date Axis

* Prevents Horizontal Date Scale

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [DEV-4215] Fix filters on brush charts (#1327)

* [4215a] Fix colors, filters on Brush chart

* [DEV-4215a] Clean code

* [DEV-4215a] Update legend positions on dashboards

* Dev 7902 (#1329)

* Changes Bar Width Calc Time Scale

* Fixes Stacked Bar Chart Date Axis

* Prevents Horizontal Date Scale

* Fix for Bar Placement

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [DEV-4215b] Fix useEffect dependency (#1330)

* [DEV-7938] Add logic to display zero data labels (#1332)

* [DEV-7938] Add logic to display zero data labels

* [DEV-7938] Add zero data display labels

* [dev-7840][dev-6574] Api filter Fixes (#1325)

* dev-7840 and dev-6574 filter fixes

* [dev-7840] fixed async filter fetch

* dev-6574 fixed child parent filter issue

* [dev] 4.24.6 > resolve console errors for respiratory page

* [dev] resolve tooltip issue on us maps

* [table-editor] Add guard (#1335)

* Fix for Legend Toggle Geocode Hovers (#1331)

* [DEV-4215] Update Brush (#1340)

* [DEV-4215c] Update Brush

* [DEV-4215c] Add tooltips to brush

* [DEV-8402] [DEV-8308]  (#1337)

* Fixes Horizontal Charts Duplicating Config

* Changes Padding Back to Size

* Fixes Size and Offset Inputs for Vert/Horiz Bars

* Fix for Paired Bar Chart

* [DEV-8261] Keeps Thicker Outline on Selected State When Hover (#1321)

* [dev] 4.24.6 > Fix Horizontal Stack Issue

* [contrast] Update color fn (#1341)

* [contrast] Update color fn

* [contrast] cleanup

* [dev] 4.24.6 > Update sankey to use proper keys automatically

* 4.24.5 tooltip hotfix

* [dev] tooltip hotfix

* FIX: [dev-8332][dev-7696] chart filter columns and footnotes (#1342)

* dev-8332 bug fix for chart filter columns

* reverted dashboard changes

* dev-7696 footnotes fix

* [DEV-8307] Adds Tooltip to Y Axis Number of Ticks (#1344)

* [DEV-7953] Hide first grid lines when axis is off (#1333)

* [DEV-8461] Update Horizontal bars (#1343)

* [DEV-8461] Update Horizontal bars

* [DEV-8461] Update label

* [DEV-8461] Update padding

* [DEV-8461] Update variables

* [DEV-7795] Annotations (#1334)

* [annotations] annotation start

* [annotations] continue working on annotations

* [annotations] add responsive options

* [annotations] add scaling for annotations in

* [annotations] 4.24.4 > Annotations

* [annotations] resolve drag and drop

* [annotations] 4.24.4 > Annotation Scaling Updates

* [annotations] working on annotations

* [annotations] continue working on annotations

* [annotations] add scaling for annotations in

* [annotations] annotations working

* [annotations] annotations working

* [annotations] continue work on annotations

* [annotations] 4.24.4 > Annotation scaling on date/time

* [annotations] working on markers

* [annotations] 4.24.5 > Annotation Updates

* [annotations] 4.24.5 > stop annotation from breaking on new.

* [annotations] update style of annotation

* [annotations] add bend

* [annotations] continue work to move

* [annotations] 4.24.5: Scaling for mobile labels

* [annotations] still working on annotation scaling

* [annotations] continue work on label positioning

* [annotations] scaling working

* [annotations] start adding in snapTo logic

* [annotations] 4.24.5 > Annotations without snap to resolved

* [annotations] center annotation when adding

* [annotations] continued work on annotations

* [annotations] Start scaffolding storybook items

* [annotations] add examples

* [annotations] add examples

* [annotations] delete files

* [annotations] cleanup

* [annotations] 4.24.5 > Annotation Feature

* [annotations-maps] map anontations

* [annotations-maps] continue work on map annotations

* [annotations-maps] 4.24.5 > Map Annotation Updates

* [annotations] test

* [annotations] Adjust width based on true svg dimensions

* [annotations] updates for line type when none

* [annotations] Annotation Updates for curved lines

* [annotations] add check for associate series

* [annotations] add bezier

* [annotations-maps] stash

* [annotations-maps] continue working on annotation scaling

* [annotations-maps] organization updates

* [annotations-maps] 4.24.6 > Annotations

* [annotations-maps] remove connection location

* [DEV-8314] 4.24.6 > Update Sankey messaging (#1347)

* [DEV-7902] Changes Bar Width Calc Time Scale (#1336)

* Changes Bar Width Calc Time Scale

* Fixes Stacked Bar Chart Date Axis

* Prevents Horizontal Date Scale

* Fix for Bar Placement

* Fixes Stacked Bar Position When Using Date Scale

* [DEV-7902] fix region size

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [dev] [styles] update input range slider

* [DEV-7977a] Update scatter plot tooltips (#1349)

* [dev] update annotation spacing

* [dev] 4.24.6 > fix colorScale issue

* [DEV-8346] resolve dashboard tooltip issue (#1354)

* resolve icon issue

* [DEV-8519] Show Territory Labels on Hex Maps (#1355)

* [dev] 4.24.6 > fix colorScale issue

* [DEV-8519] 4.24.6 > Show labels on hex maps

* Bump ws from 6.2.2 to 6.2.3 (#1361)

* Update README.md

* Publish

 - @cdc/chart@4.24.4
 - @cdc/core@4.24.4
 - @cdc/dashboard@4.24.4
 - @cdc/data-bite@4.24.4
 - @cdc/editor@4.24.4
 - @cdc/filtered-text@4.24.4
 - @cdc/map@4.24.4
 - @cdc/markup-include@4.24.4
 - @cdc/waffle-chart@4.24.4

* Publish

 - @cdc/chart@4.24.5
 - @cdc/core@4.24.5
 - @cdc/dashboard@4.24.5
 - @cdc/data-bite@4.24.5
 - @cdc/editor@4.24.5
 - @cdc/filtered-text@4.24.5
 - @cdc/map@4.24.5
 - @cdc/markup-include@4.24.5
 - @cdc/waffle-chart@4.24.5

* Bump ws from 6.2.2 to 6.2.3

Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@6.2.2...6.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 (#1358)

* Update README.md

* Publish

 - @cdc/chart@4.24.4
 - @cdc/core@4.24.4
 - @cdc/dashboard@4.24.4
 - @cdc/data-bite@4.24.4
 - @cdc/editor@4.24.4
 - @cdc/filtered-text@4.24.4
 - @cdc/map@4.24.4
 - @cdc/markup-include@4.24.4
 - @cdc/waffle-chart@4.24.4

* Publish

 - @cdc/chart@4.24.5
 - @cdc/core@4.24.5
 - @cdc/dashboard@4.24.5
 - @cdc/data-bite@4.24.5
 - @cdc/editor@4.24.5
 - @cdc/filtered-text@4.24.5
 - @cdc/map@4.24.5
 - @cdc/markup-include@4.24.5
 - @cdc/waffle-chart@4.24.5

* Bump braces from 3.0.2 to 3.0.3

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [hide-annotations] remove annotations from 4.24.6 (#1364)

* [hide-brush-functionality] hide brush functionality for 4.24.6 (#1365)

* Feature/dev 8359 (#1356)

* [DEV-8359] Data Suppression Enhancements

* [DEV-8359] Update fix issues

* [DEV-8359] Remove old code

* [DEV-8359] Update

* [DEV-8359] Fix label

* Dev 7902 regression (#1367)

* Fixes Confidence Interval Position With Date-Time Scale

* Improves Date-Time Bar Width Logic for Few Bars

* [hotfix] Prevents Crash Caused by Deleted Configs (#1371)

* Fixes Bar Widths Not Correct (#1359)

* [hotfix] Fixes Dashboard Columns Not Wrapping (#1375)

* [DEV-8209] Bugfix/dashboard preview (#1380)

* [dashboard-preview] Fixed data load function

* [dashboard-preview] Shortern the functions

* Fixes Excessive Space Beneath Axis Issue (#1382)

* Fix for County Tooltip Position (#1388)

* Dev (#1431)

* [DEV-8444] Sankey > Update Tooltips and Types (#1348)

* [DEV-8445] 4.24.6 > Move chart height selection up in the editor (#1351)

* [DEV-8312] Remove Data Designer Steps for Sankey (#1352)

* [maps] organize helper functions and add tests (#1377)

* [maps] organize helper functions and add tests

* [maps] update test locations

* bug: [dev-8575] ardi multi viz (#1374)

* bug dev-8575 ardi multi viz

* refactored from comments

* Testing pipeline (#1345)

* unit testing pipeline

* removed matrix strategy

* enhancement: [DEV-8191] multi select and pivot table updates (#1363)

* enhancement dev-8191 multi select and pivot table updates

* removed pivot test from filters since filter doesnt do pivot now

* [DEV-8234] Fix Date/category axis date orders (#1381)

* [dev] add pr template back in

* [dev] test casing

* [dev] Storybook > resolve deploy issue

* [hotfix] Fixes Crash When Switching from Combo to Bar (#1387)

* [DEV-8576] Update tooltip for zero & null values (#1384)

* [DEV-8576] Update tooltip for zero & null values

* [DEV-8576] Update function

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [hotfix] storybook and testing pipeline updates (#1394)

* [process-testing] process testing

* [process-testing] bump

* [process-testing] remove react testing library test

* [process-testing] remove comment

* added svg fix

---------

Co-authored-by: Lacey <pro7@cdc.gov>

* [DEV-7286] 4.24.7 > Inclusive Quantile Legend Opt In (#1353)

* [DEV-7286] 4.24.6 > Inclusive Quantile Legend Opt In

* [DEV-7286] Update logic and default values

* [DEV-7286] update coveUpdateWorker logic for 4.24.7

* [DEV-7286] Review Feedback

- Use lodash for unique values
- Reduce file size by removing large data files
- Compartmentalize functions for 4.24.7 updates

* [DEV-7286] Remove duplicate example file

* [DEV-8667] Add filled circles to line effect (#1385)

* [DEV-8667] Add Filled Circles to Line Effect

* [DEV-8667] Update tooltip text

* [DEV-8667] Update style

* [DEV-8667] update const

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [DEV-8445] update chart height tooltip (#1395)

* [DEV-8445] 4.24.6 > Move chart height selection up in the editor

* Fix for County Tooltip Position (#1388)

* [DEV-8445] Add chart height tooltip

---------

Co-authored-by: mpallansch <matthew.pallansch@gmail.com>

* Feature/dev 8312 (#1396)

* [DEV-8312] Remove Data Designer Steps for Sankey

* [DEV-8312] remove columns panel on sankey diagrams

* [dev] 4.24.7 > remove bar borders on line charts

* [DEV-8312] add configure button to sankey setup steps (#1398)

* [DEV-8312] Remove Data Designer Steps for Sankey

* [DEV-8312] remove columns panel on sankey diagrams

* [DEV-8312] add configure your data button to sankey

* [DEV-8622] 4.24.7 > remove unnecessary fields on sankey diagrams (#1399)

* feature: [dev-8574] Advanced Editor updates (#1372)

* feature dev-8574 advanced editor updates

* added fixes

* fixed imports in svg imports

* [DEV-7795] Responsive Annotations (#1397)

* [annotations] annotation start

* [annotations] continue working on annotations

* [annotations] add responsive options

* [annotations] add scaling for annotations in

* [annotations] 4.24.4 > Annotations

* [annotations] resolve drag and drop

* [annotations] 4.24.4 > Annotation Scaling Updates

* [annotations] working on annotations

* [annotations] continue working on annotations

* [annotations] add scaling for annotations in

* [annotations] annotations working

* [annotations] annotations working

* [annotations] continue work on annotations

* [annotations] 4.24.4 > Annotation scaling on date/time

* [annotations] working on markers

* [annotations] 4.24.5 > Annotation Updates

* [annotations] 4.24.5 > stop annotation from breaking on new.

* [annotations] update style of annotation

* [annotations] add bend

* [annotations] continue work to move

* [annotations] 4.24.5: Scaling for mobile labels

* [annotations] still working on annotation scaling

* [annotations] continue work on label positioning

* [annotations] scaling working

* [annotations] start adding in snapTo logic

* [annotations] 4.24.5 > Annotations without snap to resolved

* [annotations] center annotation when adding

* [annotations] continued work on annotations

* [annotations] Start scaffolding storybook items

* [annotations] add examples

* [annotations] add examples

* [annotations] delete files

* [annotations] cleanup

* [annotations] 4.24.5 > Annotation Feature

* [annotations-maps] map anontations

* [annotations-maps] continue work on map annotations

* [annotations-maps] 4.24.5 > Map Annotation Updates

* [annotations] test

* [annotations] Adjust width based on true svg dimensions

* [annotations] updates for line type when none

* [annotations] Annotation Updates for curved lines

* [annotations] add check for associate series

* [annotations] add bezier

* [annotations-maps] stash

* [annotations-maps] continue working on annotation scaling

* [annotations-maps] organization updates

* [annotations-maps] 4.24.6 > Annotations

* [annotations-maps] remove connection location

* [annotations-maps] Annotations > handle tabbing for annotations

* [annotations-maps] Start work on annotation list dropdown

* [annotations-maps] test

* [annotations-maps] continued work on labels

* [annotations-maps] Chart Annotation Updates

* [annotations-maps] continue work on annotations

* [annotations-maps] improve annotation dragging status

* [annotations-maps] update map annotations drag state

* [annotations-maps] testing locations

* [annotations-maps] 4.24.7 > annotation updateS

* [DEV-7795] part of merge

* [DEV-7795] remove bad import

* [DEV-7795] 4.24.7 > updates for annotations

* [DEV-7795] update saved dimensions when screen size is changed

* [DEV-7795] 4.24.6 > annotation update

* Attempts to Fix Positioning

* [DEV-7795-matt] Annotation Panel Changes on Charts

---------

Co-authored-by: mpallansch <matthew.pallansch@gmail.com>

* [DEV-4215] add brush functionality (#1386)

* [DEV-4215f] Add d3 Brush

* [DEV-4215f] Update brush

* [DEV-4215f] Add brush margin

* [DEV-4215f] remove redundant file

* [DEV-4215f] update rect element

* [DEV-4215f] update text element

* [DEV-4215f] Fix small errors

---------

Co-authored-by: Adam Doe <17502761+adamdoe@users.noreply.github.com>

* [dev] fix svg paths

* [dev] Revert "[DEV-4215] add brush functionality (#1386)"

This reverts commit c7e633f.

* [dev] Revert "feature: [dev-8574] Advanced Editor updates (#1372)"

This reverts commit 56d002e.

* Feature [dev-8574] advanced editor updates (#1401)

* feature dev-8574 advanced editor updates

* added fixes

* fixed imports in svg imports

* fixed csv imports

* [dev] Revert "[DEV-8576] Update tooltip for zero & null values (#1384)

* [DEV-8727] Update missing data label (#1402)

* Bug: [Dev-8568] COVE: Dashboard Filter Values Not Updating From Data Change (#1370)

* Updates Dashboard Filters on Load of Dynamic Data

* Adds Example Config

* Removes Reference to Moved Function

* [DEV-8669] Fix bar labels font size (#1400)

* [dev] 4.24.7 > Update PR Template

* [dev] fix typos

* [DEV-8595] Add guards for sankey data (#1405)

* [DEV-8397] Fix CDC logo overlap territories (#1404)

* [DEV-8121] update table links font sizes (#1403)

* [DEV-8767] Fix formatter to handle strings properly (#1407)

* Feature: [dev-8409] dashboard filter refactor (#1390)

* feature dev-8490 dashboard filter refactor

* fixed conflicts

* added select from existing

* added fix for delete logic, and added fix for showMissingDataCellValue

* [DEV-8698] Applies Filters on MultiDash Switch (#1389)

* Applies Filters on MultiDash Switch

* Combines UseEffects

* [DEV-7763] Expand Collapse Buttons (#1360)

* fix [dev-8409] dashboard filters - changeFilterActive (#1410)

* [DEV-6410d] Add single series tooltip for Area and Line chart (#1406)

* [DEV-6410d] Add single series tooltip for Area and Line chart

* [DEV-6410d] update tooltips

* [DEV-6410d] Update function declaration

* Removes Extra Code From Merge Issue (#1409)

* Removes Extra Code From Merge Issue

* Name Change

* [DEV-8121a] Update font size (#1413)

* Feature/dev 8796 (#1411)

* [horizontal-labels] Fix labels issue

* [horizontal-labels] Update labels for bars

* [horizontal-labels] Update text padding

* [DEV-8796a] Add new test file (#1415)

* [dev] fix pie chart

* [dev] Fixes tooltip issue with forecasting charts

* [DEV-8821] fixes emergency dept visits page (#1417)

* [DEV-8832] add checks for data in filterVizData.ts (#1418)

* [dev] marker updates for annotations

* [dev] 4.24.7 > Annotation dropdown classes fix

* [dev] 4.24.7 hotfixes

* fix dev-8409 fixed filter preview styling and typo (#1420)

Co-authored-by: william Lacey <josh@williams-MacBook-Air.local>

* [dev] hotfix > annotation indexes

* [DEV-8846] Handle null values properly in table & tooltip (#1423)

* [DEV-8846] Handle null values properly in table & tooltip

* [DEV-8846] Update test case

* [dev] resolve geocode map

* added multi-tab fix (#1424)

* Dev 8698 and dev 8568 fixes (#1425)

* Fixes Multi-Dashboard Crash

* Fixes Chart Filter Not Updating From Data

* Fix: [dev-8574] advanced editor (#1428)

* fix dev-8574 for large files in advanced editor

* removed comment

* fix/ dev-8574 needed another field collapsed (#1429)

---------

Co-authored-by: Josh Lacey <williamjoshualacey@gmail.com>
Co-authored-by: Atash3000 <31108020+Atash3000@users.noreply.github.com>
Co-authored-by: mpallansch <matthew.pallansch@gmail.com>
Co-authored-by: Lacey <pro7@cdc.gov>
Co-authored-by: Matt-DiPaolo <125307923+Matt-DiPaolo@users.noreply.github.com>
Co-authored-by: william Lacey <josh@williams-MacBook-Air.local>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Atash3000 <31108020+Atash3000@users.noreply.github.com>
Co-authored-by: mpallansch <matthew.pallansch@gmail.com>
Co-authored-by: Josh Lacey <williamjoshualacey@gmail.com>
Co-authored-by: Matt-DiPaolo <125307923+Matt-DiPaolo@users.noreply.github.com>
Co-authored-by: Matthew DiPaolo <syf8@cdc.gov>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lacey <pro7@cdc.gov>
Co-authored-by: william Lacey <josh@williams-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlacey joshlacey joshlacey left review comments

@adamdoe adamdoe adamdoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpallansch @adamdoe @joshlacey