-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SmartPad support #439
Add SmartPad support #439
Conversation
Added a new option under KeyBindings to allow key presses from the SmartPad app. Also documented macros in keymap.cpp
improved comments and allowed both [return] and [enter] keys to press [enter] button
bc6dda6
to
8b515c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on linux (with xkb_options srvrkeys:none
).
So hm, on macOS, some keys don't work, and most keys that work don't get released (in fact, only Enter seems to behave fine)
|
[enter] is the only key that TI implemented sensibly into Smartpad. By default, [enter] on the calculator simply maps to [enter] on a keyboard. That's probably why it works reliably. The rest of the keys utilize some combination of [meta] and the [ctrl], [alt], or [shift] keys. Maybe the issue lies with global keyboard shortcuts? I read you can turn them off on Mac by doing:
|
Eh well, it's not nice to have the user change their settings, so I won't do that especially because I use some :P |
I'm not sure what SV is? |
SmartView CE, I mean. |
This may not be the best solution, but I found a way to disable all shortcuts: https://stackoverflow.com/questions/5311459/disable-keyboard-shortcut |
So hm, should we merge this addign a warning that it may only work correctly under some circumstances? |
bump I think this was merged? Can we close the PR? |
How does it behave on Windows? |
EDIT: See #439 (comment) instead! Original comment: Perhaps this PR should look into disabling the Office shortcut while CEmu is open? |
Well, considering it has global conflicts on both Windows and macOS, maybe either:
|
Looking at the code in this PR, it appears that the Office shortcut is only used with function keys, so it wouldn't be necessary to use the full OfficeKeyFix. The real question is whether the registry tweak applies instantly without needing to restart explorer.exe, in which case it might be a viable option. Edit: Actually, looking at OfficeKeyFix, I wonder if registering hotkeys with the function keys we're using would prevent the office shortcut from being triggered as well. |
I just now retested this and the behavior seems to have changed. Office no longer opens whenever ctrl+alt+shift+win+anykey is pressed. It only opens when a valid shortcut is pressed (i.e. ctrl+alt+shift+win+d for onedrive). I was unable to get Office to open anymore using SmartPad so I don't think this is any issue anymore on Windows. |
Probably depends on the Windows/office version then I guess. In any case,
still probably warrants a warning shown to the user.
|
Can anyone take care of this before we release v2.0? |
680107b
to
f4e2c18
Compare
Added new option to Key Bindings under the General Settings to select 'SmartPad'. This will allow a user to connect their calculator (running the SmartPad app) to their computer, and control the CEmu Keypad with it.
Testing needed on Windows:
Pressing a key that contains the combination Alt+Ctrl+Win+Shift on Windows 10 will launch the Office application (or a webpage asking you to download Office). I have already disabled this via a Registry tweak so I cannot test. I need to be sure this nuisance won't appear on other's machines.