Skip to content

parser_yin BUGFIX when adding the same module, after free the loading module, the 'ctx->models.list[i]' is change, not exist module yet #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

parser_yin BUGFIX when adding the same module, after free the loading module, the 'ctx->models.list[i]' is change, not exist module yet #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8dbe32
parser_yin BUGFIX when adding the same module, after free the loading…
Nov 10, 2015
2a17a4e
parser_yin BUGFIX when adding the same module, after free the loading…
Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/parser_yin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5056,6 +5056,7 @@ yin_read_module(struct ly_ctx *ctx, const char *data, int implement, struct unre
{
struct lyxml_elem *yin;
struct lys_module *module = NULL, **newlist = NULL;
struct lys_module *existmod = NULL;
const char *value;
int i;

Expand Down Expand Up @@ -5113,15 +5114,16 @@ yin_read_module(struct ly_ctx *ctx, const char *data, int implement, struct unre
/* both have the same revision -> we already have the same module */
/* so free the new one and update the old one's implement flag if needed */
lyxml_free_elem(ctx, yin);
existmod = ctx->models.list[i];
lys_free(module, 0);
unres->count = 0;

LOGVRB("Module %s already in context", ctx->models.list[i]->name);
LOGVRB("Module %s already in context", existmod->name);

if (implement && !ctx->models.list[i]->implemented) {
lyp_set_implemented(ctx->models.list[i]);
if (implement && !existmod->implemented) {
lyp_set_implemented(existmod);
}
return ctx->models.list[i];
return existmod;
}
}
/* else (both elses) keep searching, for now the caller is just adding
Expand Down