This repository was archived by the owner on Sep 19, 2022. It is now read-only.
check import script for OIDC and SSP #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dBucik
reviewed
Apr 27, 2021
| import datetime | ||
|
|
||
| # Replace with correct path | ||
| FILE_PATH = 'testdir/test.csv' |
There was a problem hiding this comment.
How to change it? Does it have to be hardcoded in this script?
I would prefer reading some environment variable, or reading a special config file, consuming a request parameter or something similar.
| current_time = datetime.datetime.now() | ||
|
|
||
| # Replace with correct time limit | ||
| time_limit = datetime.timedelta(hours=2, minutes=30) |
There was a problem hiding this comment.
Again, how the parameter will be passed?
| # Replace with correct time limit | ||
| time_limit = datetime.timedelta(hours=2, minutes=30) | ||
|
|
||
| with open(FILE_PATH) as f: |
There was a problem hiding this comment.
Perhaps we should mention the expected format of the file contents.
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/python3 | |||
There was a problem hiding this comment.
@vyskocilpavel We need to decide the final version of the sync output and how the probe should respond.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.