[CHERIoT] ELF/Writer: import entry permissions #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks fine as long as this is the direction we're going. |
|
@nwf Do you still want this? |
|
I think it probably is the right approach. It might not be useful, but is easier to not use it than to add it later. |
nwf
force-pushed
the
20250625-cheriot_import_loadglobal
branch
from
49f5b47 to
13d53ac
Compare
nwf
force-pushed
the
20250625-cheriot_import_loadglobal
branch
from
13d53ac to
0117a7d
Compare
xdoardo
approved these changes
Aug 11, 2025
The loader reserves 8, not 4, bits for permission flags; the linker should agree.
I'm stealing one of the heretofore unused flags for PermitLoadGlobal. See CHERIoT-Platform/cheriot-rtos#547
nwf
force-pushed
the
20250625-cheriot_import_loadglobal
branch
from
0117a7d to
a7980d9
Compare
resistor
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loader was reserving 8, not 4, bits for permission flags, and I'm stealing one of the heretofore unused ones for PermitLoadGlobal.