Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding high-fidelity option to meshgen for meshing hardened shorelines/coastal structures #264

Merged
merged 24 commits into from
Feb 28, 2024

Conversation

WPringle
Copy link
Collaborator

@WPringle WPringle commented Apr 4, 2022

No description provided.

omouraenko and others added 8 commits October 26, 2018 16:58
Fixed an error when obj.contourfile has more than 1 item.
Fixed error when finputname has more than 1 item.
Update to geodata.m from Oleg to display information when more then one file is present.
Update diagnostic info when reading shapefiles in Read_shapefile.m.
@krober10nd
Copy link
Collaborator

Looks like there was a formatting issue with meshgen.m and it shows up as 1000 lines changed...

@krober10nd
Copy link
Collaborator

Keep in mind, this approach is set up to work for a single domain. You'll need to create a nested function inside mesh1d to correctly handle the multiscale case.

Also keep in mind the pseudo deltaT for the 1d mesh generation problem should be pretty small or otherwise it goes numerically unstable.

@krober10nd
Copy link
Collaborator

Moving this along a bit.

  • Merged this working branch with the latest master
  • Included and updated working codes to automatically form fixed point constraints if the user specified the domain to be "high-fidelity".
  • In these domains, all islands and mainland boundaries become breaklines in the triangle connectivity which is useful if you had hardened structures that need to be well represented.
  • This however also means that if your shoreline is very detailed and you aren't creating a sufficiently fine resolution mesh, the fixed connectivity can become problematic. Often this can be resolved by pruning vector data in a GIS application.
  • Fixed point and edge creation occurs when instancing a meshgen object not when building it. The logical behind that design is so that users can just call meshgen to develop the fixed points and edges but not build the mesh yet. Note you can plot those constraints with
...
mshopts = meshgen('ef',fh,'bou',gdat);
mshopts.plot()

The only changes the user needs to make are adding the high_fidelity numerical flag 1 to the geodata class constructor they want to employ the automatic generation of point and edge constraints.

gdat = geodata('shp',coastline,'bbox',bbox,'h0',min_el,'high_fidelity',1);
Screenshot 2024-02-10 at 8 23 37 PM

Constraints are displayed during meshing as blue points.

Screenshot 2024-02-10 at 8 37 29 PM

@krober10nd krober10nd marked this pull request as ready for review February 11, 2024 22:19
@WPringle
Copy link
Collaborator Author

WPringle commented Feb 27, 2024

TestJBAY.m not passing (Example_5b_JBAY_w_weirs.m). On further inspection appears weirs are not appearing correctly:
Projection branch result zoom-in:
image
This branch result zoom-in:
image

Can work out what changed wrt to the weir stuff?

WPringle and others added 2 commits February 27, 2024 13:40
Restoring mesh imprv strategy in absence of high_fidelity mode.
@krober10nd
Copy link
Collaborator

I have restored a mesh improvement strategy that improves the element qualities nearby the weirs. This will be auto deactivated when using the high fidelity mode. The JBAY test produced a difference of 6% in total number of nodes from the test value but the more important part is the weirs were correctly meshed.

@WPringle
Copy link
Collaborator Author

WPringle commented Feb 28, 2024

@krober10nd It looks good to me, can you do the approval and merging and new version release?

@krober10nd krober10nd merged commit f6125ef into Projection Feb 28, 2024
@krober10nd krober10nd deleted the enhancement/high-fidelity branch February 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants