Multiple changes after throughout testing #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added '--no-check-certificate' for wget * Added 'pause' in the end
* Windows version of 'setup.sh'
* Run 'setup_oceanmesh2d' to set paths
* Removed 'addpath' call, use 'setup_oceanmesh2d' once instead * Added plotting * Fixed section breaks
* Run all examples
* Removed 'addpath', use 'setup_oceanmesh2d' instead * Removed 'exit' call as it is called after 'error', therefore will never execute * Fixed if statements
* Added option to keep zip file * Added more reporting * Replaced 'powershell' with 'tar' in batch file (tar is available in Windows 10)
* Renamed back to original name * Moved to 'datasets' to be consistent with other data for examples
|
Thanks very much @omouraenko @WPringle lets merge this into #264 and then resolve any conflicts there? |
|
BTW, in case someone does not know, when checking "Files changed", one can add "?w=1" to the URL to omit differences in whitespaces. This option is also available under Settings (gear icon). |
I'm not sure which is better, but it may be fine to leave here, but just need to decide which one to pull into projection first. If we do this first then it would be equivalent to your suggestion I think. |
krober10nd
approved these changes
Feb 23, 2024
Added in record of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Thank you.