Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ATAC-seq DM to receive common report file #502

Merged
merged 16 commits into from
Oct 27, 2021
Merged

Update ATAC-seq DM to receive common report file #502

merged 16 commits into from
Oct 27, 2021

Conversation

roshni-b
Copy link
Contributor

@roshni-b roshni-b commented Oct 8, 2021

What

Moves the report file to the preamble section of the template so it is expected batch-level instead of sample-level.
Actual changes.

Why

To be compatible with GD2CAR ATAC-seq data

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - Documentation in docs/ has be regenerated and README has been updated to explain major changes & new features
  • Package version - Manually bumped the Schemas package version in cidc_schemas/__init__.py

@roshni-b roshni-b mentioned this pull request Oct 13, 2021
6 tasks
@roshni-b roshni-b marked this pull request as ready for review October 15, 2021 12:49
@roshni-b roshni-b marked this pull request as draft October 26, 2021 20:32
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 258287 lines exceeds the maximum allowed for the inline comments feature.

@scvannost scvannost marked this pull request as ready for review October 27, 2021 15:53
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 258241 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2021

Code Climate has analyzed commit 8011d32 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (0.0% change).

View more on Code Climate.

@roshni-b
Copy link
Contributor Author

💯

@scvannost scvannost merged commit ee6f628 into master Oct 27, 2021
@scvannost scvannost deleted the atac-seq branch October 27, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants