Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mIF: make Imaging date optional #510

Merged
merged 2 commits into from
Nov 4, 2021
Merged

mIF: make Imaging date optional #510

merged 2 commits into from
Nov 4, 2021

Conversation

roshni-b
Copy link
Contributor

@roshni-b roshni-b commented Nov 3, 2021

What

mIF S1609 - allow imaging date to be an empty field

Why

MD Anderson doesn't collect this info.

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - Documentation in docs/ has be regenerated and README has been updated to explain major changes & new features
  • Package version - Manually bumped the Schemas package version in cidc_schemas/__init__.py

@codeclimate
Copy link

codeclimate bot commented Nov 3, 2021

Code Climate has analyzed commit abae860 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (0.0% change).

View more on Code Climate.

@roshni-b roshni-b merged commit 1fedd16 into master Nov 4, 2021
@roshni-b roshni-b deleted the imaging-date branch November 4, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants