Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-1410 json schema support for clinical data participant counts #540

Closed
wants to merge 3 commits into from

Conversation

JamesProvencher
Copy link
Contributor

What

Describe very concisely what this Pull Request does.

Why

Describe what motivated this Pull Request and why this was necessary. Link to the relevant JIRA Issue. Ex. Closes CIDC-1086

How

Describe details of how you implemented the solution, outlining the major steps involved in adding this new feature or fixing this bug. Provide code-snippets if possible, showing example usage.

Remarks

Add notes on possible known quirks/drawbacks of this solution.

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - Documentation in docs/ has be regenerated and README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the Schemas package version in cidc_schemas/__init__.py

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2022

Code Climate has analyzed commit d5e7be6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.1% (0.0% change).

View more on Code Climate.

@JamesProvencher JamesProvencher deleted the clinical-part-counts branch July 28, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant