Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-1520 patch olink metadata parser #556

Merged
merged 2 commits into from
Oct 26, 2022
Merged

CIDC-1520 patch olink metadata parser #556

merged 2 commits into from
Oct 26, 2022

Conversation

scvannost
Copy link
Contributor

@scvannost scvannost commented Oct 26, 2022

What

Expand handling of olink NPX files in extra metadata parser to match unprism

Why

CIDC-1520 Olink parsing debug -- "OlinkID" vs "Olink ID"

ran into differences between extra metadata parser and unprism handling of NPXs

How

  • Use same logic as in unprism -> convert to lowercase and remove spaces
  • Change spacing in 1 of 2 example NPXs in tests to prevent reversion

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - Documentation in docs/ has be regenerated and README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the Schemas package version in cidc_schemas/__init__.py

@codeclimate
Copy link

codeclimate bot commented Oct 26, 2022

Code Climate has analyzed commit 255b353 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.4%.

View more on Code Climate.

@scvannost scvannost merged commit f6e0539 into master Oct 26, 2022
@scvannost scvannost deleted the olink-patch branch October 26, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants