Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-876 change file derivation to return None instead of erroring when not defined #566

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

scvannost
Copy link
Contributor

Why

  • CIDC-876 derive_files_from_... cloud functions throw errors when no derivation is implemented

How

  • Remove hardcoded raise

Remarks

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - Documentation in docs/ has be regenerated and README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the Schemas package version in cidc_schemas/__init__.py

@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit 15923f5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.5% (0.0% change).

View more on Code Climate.

@scvannost scvannost merged commit 57ffbb6 into master Nov 11, 2022
@scvannost scvannost deleted the derive-files branch November 11, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants