Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test on kernel major and minor version (FILE-6344). Issue 1367 #1388

Merged
merged 1 commit into from
May 14, 2024

Conversation

xnoguer
Copy link
Contributor

@xnoguer xnoguer commented Apr 26, 2023

This pull request fixes issue 1367: #1367

Tested on:

  • Debian 11, kernel 5.10.0. Failure and success.
  • Ubuntu 19.04, kernel 5.0, which skipped the test because on minor version 0. Failure and success.

@xnoguer xnoguer changed the title Fixing test on kernel major and minor version (FILE-6344) Fixing test on kernel major and minor version (FILE-6344). Issue 1367 Apr 26, 2023
Copy link

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is happened on my system (kernel 6.1), and I verified that this PR changes fixes the original issue.

wdyt @mboelen ?

@mboelen mboelen merged commit 65ac3e6 into CISOfy:master May 14, 2024
@mboelen
Copy link
Member

mboelen commented May 14, 2024

Thanks, merged!

@xnoguer should we also add a "catch" for unspecified future versions? For example, showing an exception if the kernel is at higher levels, or not needed as support for the checked options is now covered fully, including future-proof testing?

@xnoguer
Copy link
Contributor Author

xnoguer commented May 16, 2024

@mboelen I don't think it's needed. If the test didn't make sense from a future kernel release onward (let's say X.Y), then we would have to change the code so that PREQS_MET for test FILE-6344 is only set to "YES" when kernel version is between 3.3 and X.Y.
But there's no way to know this now (as far as I'm aware). In fact it would mean that the hidepid option stops being used or adds new possible values force us to rewrite test FILE-6344.

@mboelen
Copy link
Member

mboelen commented May 16, 2024

Yup, makes sense. Was also my thought, but wanted to double-check with you.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants