Implemented rest of Z3 operators. Closes 147. #168
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 24 | 1 | 1.14s | ||
| ✅ PYTHON | pylint | 24 | 0 | 4.46s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 92.44% 90.90% -1.54%
==========================================
Files 19 17 -2
Lines 1297 1166 -131
==========================================
- Hits 1199 1060 -139
- Misses 98 106 +8
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| def test_copy(self): | ||
| ip = Input("ip", float, norm) | ||
| self.assertNotEqual(ip.copy(), ip) | ||
| self.assertTrue(ip.copy() is not ip) | ||
| self.assertEqual(ip.copy().name, ip.name) |
There was a problem hiding this comment.
implementing an __eq__ method could make this test neater. But very minor thing
There was a problem hiding this comment.
With my functional programming/Isabelle mindset, I have extreme reluctance in implementing custom equality methods. If it really is best practice in this context, I can do it, but I'd prefer not to
No description provided.