Skip to content

JSON concrete tests #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 25, 2023
Merged

JSON concrete tests #179

merged 13 commits into from
Apr 25, 2023

Conversation

christopher-wild
Copy link
Contributor

This PR enables concrete tests to be run using the JSON format:

"tests": [
                {
                    "name": "test1",
                    "treatment_variable": "test_input",
                    "control_value": 0,
                    "treatment_value": 1,
                    "estimator": "LinearRegressionEstimator",
                    "estimate_type": "ate",
                    "expectedEffect": {"test_output": "NoEffect"},
                    "skip": False,
                }
            ]

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 24 0 1.13s
✅ PYTHON pylint 24 0 4.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #179 (2b919ed) into main (fb06924) will increase coverage by 0.08%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   93.29%   93.37%   +0.08%     
==========================================
  Files          19       19              
  Lines        1312     1329      +17     
==========================================
+ Hits         1224     1241      +17     
  Misses         88       88              
Impacted Files Coverage Δ
causal_testing/json_front/json_class.py 98.13% <96.87%> (-0.48%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106f346...2b919ed. Read the comment docs.

@christopher-wild christopher-wild marked this pull request as ready for review April 19, 2023 10:51
@christopher-wild christopher-wild merged commit 72c3997 into main Apr 25, 2023
@christopher-wild christopher-wild deleted the JSON_treatment_var branch April 25, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change JSON to be treatment_var and mutation to it rather than a dict of mutations JSON frontend only accepts distributions not scalars
2 participants