Skip to content

Fixed "np.int64" is not JSON encodable from test outcomes #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

jmafoster1
Copy link
Contributor

Small fix to the Positive and Negative test outcomes such that they return native bool datatypes rather than np.bool, resulting in np datatypes being carried forward into other parts of the CTF and causing JSON encoding issues further down the line.

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 26 0 1.49s
✅ PYTHON pylint 26 0 5.65s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #241 (189c210) into main (e64469e) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          20       20           
  Lines        1408     1408           
=======================================
  Hits         1344     1344           
  Misses         64       64           
Files Changed Coverage Δ
causal_testing/testing/causal_test_outcome.py 96.96% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67213a4...189c210. Read the comment docs.

@jmafoster1 jmafoster1 requested a review from f-allian September 19, 2023 12:56
Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes

@jmafoster1 jmafoster1 merged commit 53b2a91 into main Sep 19, 2023
@jmafoster1 jmafoster1 deleted the fix-json-adequacy-bug branch September 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants