Fix: Remove spurious nodes in dot files due to \n #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 29 | 1 | 1.44s | ||
| ✅ PYTHON | pylint | 29 | 0 | 4.25s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 95.59% 95.60%
=======================================
Files 22 22
Lines 1567 1569 +2
=======================================
+ Hits 1498 1500 +2
Misses 69 69
Continue to review full report in Codecov by Sentry.
|
jmafoster1
approved these changes
Mar 12, 2024
christopher-wild
approved these changes
Mar 12, 2024
| @@ -133,7 +133,9 @@ class CausalDAG(nx.DiGraph): | |||
| def __init__(self, dot_path: str = None, **attr): | |||
| super().__init__(**attr) | |||
| if dot_path: | |||
| pydot_graph = pydot.graph_from_dot_file(dot_path) | |||
| with open(dot_path, 'r', encoding='utf-8') as file: | |||
| dot_content = file.read().replace('\n', '') | |||
There was a problem hiding this comment.
I think it may be worth adding a comment describing this, as the problem this is solving is not obvious from the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #258 by: