Skip to content

small changes for JOSS publication #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025
Merged

small changes for JOSS publication #310

merged 3 commits into from
Feb 26, 2025

Conversation

danielskatz
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (f3276c4) to head (48e636d).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          29       29           
  Lines        1856     1856           
=======================================
  Hits         1798     1798           
  Misses         58       58           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4974669...48e636d. Read the comment docs.

@jmafoster1
Copy link
Contributor

@f-allian, some of our CI tests seem to be failing with the error message

There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - Too Many Requests - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue.

Do you know why this might have suddenly started happening or what we can do about it? I gave it an hour and tried again and it still failed. Do we just need to keep waiting?

@f-allian
Copy link
Contributor

f-allian commented Feb 26, 2025

@danielskatz Thank you for your review and your suggested changes.

@jmafoster1 I've looked into this and the only test that's failing is the Code Cov upload of the report. This is caused by a permission issue because our workflow file currently expects a token-based authentication for uploads using the older version of codecov-action (v2), which of course is empty for forked repositories. The best solution is to upgrade to the latest version of Code Cov as they allow tokenless uploads from forked PRs (see their documentation). I'll do this now.

@f-allian f-allian merged commit 1240348 into CITCOM-project:main Feb 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants