Skip to content
This repository was archived by the owner on May 26, 2020. It is now read-only.

Conversation

allanmckenzie
Copy link
Member

No description provided.

@allanmckenzie allanmckenzie requested a review from matt-rich March 3, 2017 12:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.09%) to 98.907% when pulling 5252444 on move-utility-classes-from-file-service into f7bf76f on master.

@allanmckenzie allanmckenzie force-pushed the move-utility-classes-from-file-service branch from 9fbdf0d to b098c26 Compare March 3, 2017 12:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.09%) to 98.907% when pulling b098c26 on move-utility-classes-from-file-service into f7bf76f on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.09%) to 98.907% when pulling b098c26 on move-utility-classes-from-file-service into f7bf76f on master.

Copy link
Contributor

@purple52 purple52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to split these out; we can't have Liquibase and H2 as dependencies of the core utilities; core needs to be as lightweight as possible because its going to get used everywhere. Otherwise looks okay, but I didn't check for finals.

@allanmckenzie
Copy link
Member Author

Ooops - well spotted - these were intended for the test-utils project

@allanmckenzie
Copy link
Member Author

I'll move them there

@allanmckenzie allanmckenzie deleted the move-utility-classes-from-file-service branch March 3, 2017 13:44
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 93cb6ae on move-utility-classes-from-file-service into f7bf76f on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants