Skip to content

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 18, 2019

Make warnings errors, and add and fix even more warnings.

Warnings are no longer exported to Config targets. Warnings are (mostly) avoided for gtest. Library update for JSON. A warning in CI now is reported as an error.

Closes #261.

@henryiii henryiii marked this pull request as ready for review May 18, 2019 15:30
Make gtest a system library

Fixing format

Adding better method for adding warnings

Adding errors for warnings

Nicer Windows deprecated test

JSON update and drop testing timer
@henryiii henryiii force-pushed the henryiii-warnings branch from bb295d4 to 952e5bf Compare May 18, 2019 15:39
@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #281   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2879   2880    +1     
=====================================
+ Hits         2879   2880    +1
Impacted Files Coverage Δ
include/CLI/Timer.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acee69a...c1ec193. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #281   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2879   2880    +1     
=====================================
+ Hits         2879   2880    +1
Impacted Files Coverage Δ
include/CLI/Timer.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acee69a...c1ec193. Read the comment docs.

@henryiii henryiii merged commit 7b31578 into master May 18, 2019
@henryiii henryiii deleted the henryiii-warnings branch May 18, 2019 17:11
@henryiii henryiii added this to the v1.8 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warning with -Wstrict-overflow
1 participant