Skip to content

Conversation

henryiii
Copy link
Collaborator

No description provided.

@henryiii henryiii requested a review from phlptp January 19, 2020 04:09
@henryiii
Copy link
Collaborator Author

@phlptp, can you verify that I didn't miss anything obvious? Otherwise, I'll merge this and tag tomorrow.

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #408   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3580   3580           
=====================================
  Hits         3580   3580
Impacted Files Coverage Δ
include/CLI/Validators.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc757f...0f066ea. Read the comment docs.

Copy link
Collaborator

@phlptp phlptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see much mention of the CMake changes in the changelog. I know those got rolled into another PR but I think they are worth a mention directly in the changelog as they were pretty significant.

Otherwise as far as I can tell everything look good.

@henryiii henryiii merged commit dd0d8e4 into master Jan 19, 2020
@henryiii henryiii deleted the henryiii-1.9 branch January 19, 2020 23:00
@henryiii henryiii added this to the v1.9 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants