You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the new default is dimension instead of sqrt(dimension)
2. What does this mean ?
At the end of the docstring I can read:
""""Set lam and mu until a population contains more than 10% infeasibleand more than 10% feasible at the same time. Afterwards, this at least...?.. """.```
But I don't find the corresponding piece of code ?
3.
My last request for documentation is about this code
# take min or max with existing value depending on the sign average# we don't know whether this is necessaryisclose=np.abs(sign_average) <=0.2idx1=_and(_and(_or(isclose,
_and(_not(self.isequality), sign_average<=0.2)),
_or(self.mu==0, self.mu>mu_new)),
idx) # only decreaseidx2=_and(_and(_and(_not(isclose),
_or(self.isequality, sign_average>0.2)),
self.mu<mu_new),
idx) # only increaseidx3=_and(idx, _not(_or(idx1, idx2))) # othersassertnp.sum(_and(idx1, idx2)) ==0ifnp.any(idx1): # decreaseiidx1=self.mu[idx1] >0ifnp.any(iidx1):
self.lam[idx1][iidx1] *=mu_new[idx1][iidx1] /self.mu[idx1][iidx1]
self.mu[idx1] =mu_new[idx1]
ifnp.any(idx2): # increaseself.mu[idx2] =mu_new[idx2]
ifnp.any(idx3):
self.mu[idx3] =mu_new[idx3]
Which is hard to read and looks somewhat related to my 2nd point. This looks like this is to decide whether mu_new should be chosen as the new setting if the user has already set values for mu, based on the value of sign_average and other conditions. So does it relate to the quoted part of the docstring and should it be updated ?
The text was updated successfully, but these errors were encountered:
I have a few comments to make regarding the docstring of
AugmentedLagrangian.set_coefficients
1. Error in the docstring
The docstring relates to the following formula for setting the lagrangian parameter:
whereas, in the code, I can read
It looks like the new default is dimension instead of sqrt(dimension)
2. What does this mean ?
At the end of the docstring I can read:
But I don't find the corresponding piece of code ?
3.
My last request for documentation is about this code
Which is hard to read and looks somewhat related to my 2nd point. This looks like this is to decide whether
mu_new
should be chosen as the new setting if the user has already set values for mu, based on the value ofsign_average
and other conditions. So does it relate to the quoted part of the docstring and should it be updated ?The text was updated successfully, but these errors were encountered: