Fix apiVersion type inconsistency - ensure consistent number return type #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a type inconsistency bug where
apiVersion
was returned as different types depending on the source:Problem:
apiVersion
was extracted from Accept header via regex match, it returned a string (e.g.,'1'
)apiVersion
came fromdefaultVersion
option, it returned a number (e.g.,1
)Example of the issue:
Solution:
index.js
line 36 to useparseInt(version)
instead ofversion
apiVersion
consistently returns a number in both scenariosassert.strictEqual()
to prevent regressionImpact:
==
) continues to work===
) or TypeScriptFixes #33.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.