sparkbench: avoid to verify file format in SparkFuncs.scala #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 992a278 Author: Emily Curtin <emily@framebit.org> Date: Fri Feb 2 14:46:33 2018 -0500 Addressing code review comments Moves format check to front. This commit add verifyFormatOrThrow(outputDir, fileFormat) in verifyOutput(). It causes graph data generator workload failure since the workload only generate output with txt file format. But sparkbench only supports csv, parquet, etc. The confliction of file format causes the workload failure. Now remove the verifyFormatOrThrow() instead. Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 86.8% 85.98% -0.82%
==========================================
Files 33 33
Lines 750 749 -1
Branches 47 47
==========================================
- Hits 651 644 -7
- Misses 99 105 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 992a278
Author: Emily Curtin emily@framebit.org
Date: Fri Feb 2 14:46:33 2018 -0500
This commit add verifyFormatOrThrow(outputDir, fileFormat) in
verifyOutput(). It causes graph data generator workload failure
since the workload only generate output with txt file format.
But sparkbench only supports csv, parquet, etc. The confliction
of file format causes the workload failure. Now remove the
verifyFormatOrThrow() instead.
Signed-off-by: Haojian Zhuang haojian.zhuang@linaro.org