Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Using_Explorer_tools #382

Closed
wants to merge 1 commit into from

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anton-seaice
Copy link
Collaborator

This change doesn't make sense.

The notebook Using_Explorer_tools is about using the explorer in the cosima cookbook, there is no equivalent for the Intake Catalogue at this point.

I suggest we leave this recipe unchanged, at some point we might make a new notebook to explore using the Intake Catalogue.

(Maybe we should add a note encouraging people to use the Intake Catalogue, and saying this recipes is for historical reasons only)

@rbeucher
Copy link
Contributor Author

Sure. I have just created a bunch of PR based on @max-anu work. I did not go through all the changes and understand that some PRs might be irrelevant.

@anton-seaice
Copy link
Collaborator

Closing as no-change for now, we'll keep this notebook for reference for cookbook users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants