Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'False' gets removed in transformations #227

Closed
IgnaceBleukx opened this issue Feb 16, 2023 · 0 comments · Fixed by #229
Closed

'False' gets removed in transformations #227

IgnaceBleukx opened this issue Feb 16, 2023 · 0 comments · Fixed by #229
Assignees
@IgnaceBleukx

Comments

@IgnaceBleukx
Copy link
Collaborator

IgnaceBleukx commented Feb 16, 2023 •
edited
Loading

Our transformations do not cope well with 'False' atm.

For example, reify_rewrite(False) returns [] which is clearly wrong.
This is the cause of the following bug:
Model([False]).solve() returns True!!

Same holds for the linearize transformation. It crashes when trying to transform False.

But I guess some solvers do not support adding False to the solver in their API... Which is understandable but annoying for us.
@IgnaceBleukx IgnaceBleukx self-assigned this Feb 16, 2023
@IgnaceBleukx IgnaceBleukx linked a pull request Feb 16, 2023 that will close this issue
227 false gets removed in transformations #229
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnaceBleukx IgnaceBleukx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

227 false gets removed in transformations CPMpy/cpmpy
1 participant
@IgnaceBleukx