-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
227 false gets removed in transformations #229
227 false gets removed in transformations #229
Conversation
After discussion offline: will implement a |
Link to cpmpy-bigtest
…m:CPMpy/cpmpy into 227-false-gets-removed-in-transformations
We have a bunch of research code that expects I hence propose to make |
I reworked it some more. I think its looking nice, would be good to see this land rather soon, so we can base other branches on this. It tested good on bigtest (ortools) too (no noticable timing differences though, a bit to my surprise) @Wout4 and @IgnaceBleukx can you have a final look and merge? |
cpmpy/transformations/normalize.py
Outdated
if isinstance(e, Expression): | ||
if isinstance(e, NDVarArray): # sometimes does not have .name | ||
unravel(e.flat, append) | ||
elif e.name == "and": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here check for merge_and
, will add
Can confirm all tests run, for pysdd as well. |
looks good to me! |
Wasn't really sure about how to do it in pysdd...