Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 261 #274

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix 261 #274

merged 3 commits into from
Apr 21, 2023

Conversation

JoD
Copy link
Collaborator

@JoD JoD commented Mar 31, 2023 •
edited
Loading

Makes use of the invariant that reifications always have bool expressions on both sides of equality to check for them.

Fixes #261

@JoD JoD added the Simple to review Simple change to review, e.g., a oneliner. label Mar 31, 2023
@JoD JoD requested a review from Wout4 March 31, 2023 16:42
@Wout4
Copy link
Collaborator

Wout4 commented Apr 21, 2023

Looks good, clean fix!

@Wout4 Wout4 merged commit 2258074 into master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wout4 Wout4 Awaiting requested review from Wout4

Assignees
No one assigned
Labels
Simple to review Simple change to review, e.g., a oneliner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

negated_normal crashes when input contains a boolexpr compared with an numexpr.
2 participants
@JoD @Wout4