Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten does not decompose #286

Closed
wants to merge 6 commits into from
Closed

Conversation

Wout4
Copy link
Collaborator

@Wout4 Wout4 commented Apr 28, 2023

No description provided.

@Wout4 Wout4 linked an issue Apr 28, 2023 that may be closed by this pull request
@Wout4 Wout4 closed this Apr 28, 2023
@Wout4 Wout4 reopened this Apr 28, 2023
@Wout4
Copy link
Collaborator Author

Wout4 commented Apr 28, 2023

the change to get_or_make_var is a bit hacky, maybe there is a nicer way to achieve the same result

@Wout4
Copy link
Collaborator Author

Wout4 commented May 4, 2023

Actually it was not neccesary, since the negation could be moved outside get_or_make_var. I did make a change to get_or_make_var that avoids unnecessary assignments in flat output

@Wout4 Wout4 requested review from tias and IgnaceBleukx May 4, 2023 12:37
@Wout4 Wout4 linked an issue May 5, 2023 that may be closed by this pull request
@tias tias added this to the v0.9.14 milestone May 9, 2023
@Wout4 Wout4 closed this May 23, 2023
@tias
Copy link
Collaborator

tias commented May 23, 2023

if this is a cleanup, why did you close it unmerged? or it is superseded by another PR?

@Wout4
Copy link
Collaborator Author

Wout4 commented May 23, 2023

I extracted the only useful code into the get_or_make_var pr
This addressed the fact that we now decompose in flatten, but that will be resolved with the push down negation and recursive decomposition transformations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

negated_normal decomposes global constraints Xor of Circuit global constraints crashes ortools
2 participants