Improving global constraints #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnaceBleukx
changed the title
|
I changed the pull request to be more general changes to global constraints and pushed some optimizations in decompositions as well. |
tias
reviewed
May 25, 2023
|
As no comments remain here, I assume it can be merged as is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #256, changed the global cardinality constraint (GlobalCardinalityCount()) to make it more general.
Specifically, in the previous version the user had to define the exact amount of times all values appear, and could not define it only for a subset of them.
The new GlobalCardinalityCount() of this PR is in align with http://sofdem.github.io/gccat/gccat/Cglobal_cardinality.html and also with what minizinc has https://www.minizinc.org/doc-2.5.5/en/lib-globals.html. In addition, the new version complies with hakan's description in http://www.hakank.org/bprolog/global_cardinality.pl
I also checked in all the examples, if we used anywhere the GlobalCardinalityCount constraint, in order to change to the new syntax, but did not find any case.