pysdd: refactor to recursively translate into an SDD #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoD
reviewed
Jun 19, 2023
cpmpy/solvers/pysdd.py
Outdated
| elif hasattr(cpm_con, 'decompose'): | ||
| # for all global constraints: attempt to convert the decomposition | ||
| all_cons = cpm_con.decompose() # all of these must be true, conjoin | ||
| return reduce(self.pysdd_manager.conjoin, [self._pysdd_expr(a) for a in all_cons]) |
There was a problem hiding this comment.
Will this work with the new decompose globals that gives global and local constraints?
|
Looks good, but needs to synchronize with decompose tree. |
This is in the master now. |
# Conflicts: # cpmpy/solvers/pysdd.py
|
Added the new decompose-global function and simplify_boolean function to the |
|
ack, ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may benefit from having the Boolean normalizer as transformation, once it is in master, e.g. #291