Updated tuner #323
Merged
Updated tuner #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tias
approved these changes
Jun 26, 2023
cpmpy/tools/tune_solver.py
Outdated
| i = 0 | ||
| if max_tries is None: | ||
| max_tries = len(combos) | ||
| while len(combos) and i < max_tries: |
There was a problem hiding this comment.
i dont really like the config_idx below and this 'while', it should just be a simple for? If you want randomized order, maybe something like for i, param_dict in rand.shuffle(param_combinations(self.all_params)):?
There was a problem hiding this comment.
Ah yes, this tuner is indeed much simpler to code, updated
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our hyperparameter tuner and added some more documentation.
Also implemented a more naive grid search so we can easily compare the implementations.
The new hyperparameters for OR-tools are chosen according to issue #138. However, for some parameters no upper bound is given by the sat_parameters.proto file... (i.e., for example
cp_model_probing_level).