Change typecheck test for gcc #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these tests are a bit different, since they test the typecheck, so different mixes of ints and bools are given as arguments to see if a type-error is thrown. The other tests don't do that |
Dimosts
changed the title
|
ok, changed the typecheck tests then to the new version. |
|
I now see what happened, the typechecks tests were not introduced when this PR opened, thus there were no typecheck tests to change then, this only occured when merged to main, where in the meanwhile these tests have been introduced. |
|
Ok, looks good so I'll merge. Once the new master is merged into other open PR's, github will stop complaining about failed tests there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we had 2 different test functions for gcc, the test_global_cardinality_count and the test_gcc. They were doing the same thing. I had only noticed and changed the test_global_cardinality_count in my PR that was merged, and the test_gcc redundant test was left same as in the previous version, and thus now fails with the new syntax.
In this PR I just remove the redundant test test_gcc, as we already have tests in test_global_cardinality_count