sum, max, and min np like methods of NDVarArray #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking at the list of np functions in their docs: |
|
any, all, mean and prod added. I also added some tests for NDVarArray expressions. I think it is ready for a review |
|
Should we also fix issue #341 in this pull request? Can also be in another one probably |
|
I am fine both with including it in this PR or another one. Do you already know how to fix that issue? If not, I can look into it |
tias
reviewed
Jun 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding the max and min functions in NDVarArray. For now same as sum, but I plan to also implement the 'axis' and 'out' options.
Any good suggestion of what other np methods we could use?