Allow description for a constraint #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made following changes:
|
|
You could set a description for a variable as well, which i think is desirable. However some solvers use the string representation of a variable as the name to send to the solver. This should probably be changed to use the name (or uuid in another pr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For explanation techniques, its usefull to have a human-intepretable representation for a constraint.
This pull request allows a user to create a constraint and then set its description, when the constraint is printed, the description is taken instead of the
__repr__method.I guess we should take extra care for Minzinc for this one as we might convert an expression based on its string representation? But I could not see this happening anywhere.