Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests in examples if required packages not installed #384

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

Wout4
Copy link
Collaborator

@Wout4 Wout4 commented Jul 6, 2023

remove z3 test from abs

@Wout4 Wout4 linked an issue Jul 6, 2023 that may be closed by this pull request
@Wout4 Wout4 requested a review from tias July 6, 2023 14:33
@Wout4
Copy link
Collaborator Author

Wout4 commented Jul 6, 2023

I'm sure there is some more elegant way to do this but it should work

Copy link
Collaborator

@tias tias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now on fresh install.

I don't know if there is a way to catch all ModuleNotFoundErrors when the test is run, but this is also fine thx : )

@Wout4
Copy link
Collaborator Author

Wout4 commented Jul 6, 2023

ah yeah that makes more sense

@Wout4
Copy link
Collaborator Author

Wout4 commented Jul 6, 2023

messed up the commit message, but it now just checks for any modulenotfounderror

@tias
Copy link
Collaborator

tias commented Jul 7, 2023

tested in fresh venv and original system, all fine now

@tias tias merged commit 250d95d into master Jul 7, 2023
@tias tias deleted the 381-fresh-install-tests-requiring-skip-check branch July 7, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fresh install tests requiring skip check
2 participants