Solution hinting fix, when giving N-D variables and values #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosts
changed the title
|
looks good to me, but I can't get ortools to actually give me a solution that is using the hints. Is that because the problem is just too easy? |
|
We actually have a very efficient |
|
Indeed, it is cleaner that way, I didn't notice we had a function for that. Changed it to use flatlist. |
|
Did some cleanup and added a tests,good to merge now for me. |
IgnaceBleukx
approved these changes
Sep 21, 2023
# Conflicts: # cpmpy/solvers/pysat.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to issue #407
Flattening the variables and values first, before moving to the for loop of adding the hints.
Covering cases that vars and values are NDVarArrays, ndarrays or anything that has a .flat attribute + cases that the user may give lists for hinting.