New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no distributivity in flatten_model.py #426

Merged

Wout4 merged 2 commits into master from no_distributivity

Oct 19, 2023

Collaborator

Wout4 commented Oct 17, 2023

After extensive testing on the distributivity rule for conjunctions in disjunctions I came to the following conclusion:

In almost all of our used benchmarks this does not have any impact.
It seems only to be positive in very small instances where the effect is therefor minimal. I tried to construct cases where it gives big benefit but I was unable to do so.
It is very easy to construct cases where it is orders of magnitude worse than not applying distributivity, making simple problems infeasible.

Since there aren't really any cases where it is worth to do, I would just remove this code in stead of looking for a heuristic of when to apply it.

Wout4 added 2 commits

October 16, 2023 13:16


          no distributivity in flatten_model.py

d95b1a0


          Add documentation

07b9933

Wout4 merged commit 0efb8df into master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet