Globals mdd regular #478
Globals mdd regular #478
Conversation
| @@ -312,6 +312,146 @@ def value(self): | |||
| return arrval in tab | |||
|
|
|||
|
|
|||
| class MDD(GlobalConstraint): | |||
| """The values of the variables in 'array' correspond to a path in the mdd formed by the transition in 'transitions' | |||
There was a problem hiding this comment.
"the transition in 'transitions'"
Each path in the MDD will always consist of multiple transitions from 'transitions' no? (unless graph only has two layers).
So there is no "the transition".
There was a problem hiding this comment.
I like this one a lot. Very clean and elegant code. Almost all my comments a regarding some missing documentation. I really had to go deep into the actual code to understand what each section tried to achieve. Some simple comments and docstrings with high-level summaries would really go a long way.
|
Maybe merge/rebase with master and test with the new testsuite. I expect the error of the undeclared variable in value() will pop up. |
# Conflicts: # cpmpy/expressions/__init__.py # cpmpy/expressions/globalconstraints.py
|
For this to be merged we want the decompositions to work in nested case, and also add solver support for those that support mdd or regular (Minizinc for sure, not sure which ones too) |
No description provided.