Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Profile pic #163

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Implement Profile pic #163

wants to merge 24 commits into from

Conversation

ChooJeremy
Copy link

Implement uploading of profile pic of employees.
Supports #66

@ChooJeremy ChooJeremy added this to the v1.4 milestone Nov 3, 2018
@ChooJeremy ChooJeremy self-assigned this Nov 3, 2018
@coveralls
Copy link

coveralls commented Nov 3, 2018

Pull Request Test Coverage Report for Build 702

  • 37 of 41 (90.24%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 86.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/AddressBookParser.java 0 1 0.0%
src/main/java/seedu/address/logic/commands/ProfilePicCommand.java 31 34 91.18%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/storage/XmlAdaptedPerson.java 1 99.12%
src/main/java/seedu/address/storage/XmlArchiveListStorage.java 2 63.64%
src/main/java/seedu/address/model/util/SampleDataUtil.java 7 72.41%
Totals Coverage Status
Change from base Build 663: -0.2%
Covered Lines: 2930
Relevant Lines: 3375

💛 - Coveralls

@ChooJeremy ChooJeremy removed this from the v1.4 milestone Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants